On Wed, Nov 11, 2015 at 12:01:08PM +0300, Dan Carpenter wrote: > On Wed, Nov 11, 2015 at 12:43:05AM -0500, ira.weiny@xxxxxxxxx wrote: > > From: Ira Weiny <ira.weiny@xxxxxxxxx> > > > > This goto done is followed by an if (ret) break in the outer switch clause. It > > is unnecessary. > > > > Signed-off-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx> > > Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx> > > --- > > drivers/staging/rdma/hfi1/diag.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/staging/rdma/hfi1/diag.c b/drivers/staging/rdma/hfi1/diag.c > > index 2bb857b2a103..556a47591989 100644 > > --- a/drivers/staging/rdma/hfi1/diag.c > > +++ b/drivers/staging/rdma/hfi1/diag.c > > @@ -1053,7 +1053,6 @@ static long hfi1_ioctl(struct file *fp, unsigned int cmd, unsigned long arg) > > break; > > default: > > ret = -EINVAL; > > - goto done; > > } > > ret = set_link_state(ppd, dev_state); > > break; > > Wut? No it's not. Sorry, you are correct at this point in the series. I got over zealous with my splitting of this patch. This needs to be squashed into staging/rdma/hfi1: Return immediately on error Which returns here. Ira _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
