On Wed, Nov 11, 2015 at 08:39:08AM -0500, Dennis Dalessandro wrote:
> On Wed, Nov 11, 2015 at 08:25:35AM +0200, Leon Romanovsky wrote:
> >On Wed, Nov 11, 2015 at 12:34:37AM -0500, ira.weiny@xxxxxxxxx wrote:
> >>From: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx>
> >>
> >>+int snoop_send_dma_handler(struct hfi1_qp *qp, struct hfi1_pkt_state *ps,
> >>+ u64 pbc)
> >> {
> >>- pr_alert("Snooping/Capture of Send DMA Packets Is Not Supported!\n");
> >>+ pr_alert("Snooping/Capture of Send DMA Packets Is Not Supported!\n");
> >> snoop_dbg("Unsupported Operation");
> >Is it really necessary to do both print alert to message log (pr_alert) and to
> >trace buffer (snoop_dbg)?
>
> Well yes, and no. They serve two different purposes. One for users of the
> snoop feature the other for developers.
>
> However, I don't think we really even need to keep this function around
> anymore. How about we just remove it in a follow on patch, and let this one
> stand as is?
Sure, I'm fine with that.
>
> -Denny
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
