On Wed, Nov 11, 2015 at 12:43:05AM -0500, ira.weiny@xxxxxxxxx wrote: > From: Ira Weiny <ira.weiny@xxxxxxxxx> > > This goto done is followed by an if (ret) break in the outer switch clause. It > is unnecessary. > > Signed-off-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx> > Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx> Also these sign offs don't really make sense. Signed-off-by is basically like signing a legal document saying the code in this patch was not stolen from SCO UnixWare. You only need to sign if you have handled the patch. Did Dennis write this patch or did he Ack it or Review it somehow? regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel