On Wed, Nov 11, 2015 at 12:43:06AM -0500, ira.weiny@xxxxxxxxx wrote:
> From: Ira Weiny <ira.weiny@xxxxxxxxx>
>
> Set link state was not supported and so we can return early in the parameter
> checks rather than falling through the switch clause.
>
> Signed-off-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx>
> Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx>
> ---
> drivers/staging/rdma/hfi1/diag.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rdma/hfi1/diag.c b/drivers/staging/rdma/hfi1/diag.c
> index 556a47591989..a489a79dd3b6 100644
> --- a/drivers/staging/rdma/hfi1/diag.c
> +++ b/drivers/staging/rdma/hfi1/diag.c
> @@ -999,16 +999,14 @@ static long hfi1_ioctl(struct file *fp, unsigned int cmd, unsigned long arg)
> * Other are invalid.
> */
> return -EINVAL;
> + } else if (cmd == HFI1_SNOOP_IOCSETLINKSTATE) {
> + /* We do not support the old setlink state */
> + return -EINVAL;
Just delete it and let the default in the switch statement return
-ENOTTY.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
