Re: [PATCH v2 2/3] staging: unisys: convert pack pragma to __packed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 12, 2015 at 04:46:07PM -0400, David Kershner wrote:
> It was noticed that iochannel.h was still using pragmas to
> pack the datastructures, should be using __packed instead.
> 
> Signed-off-by: David Kershner <david.kershner@xxxxxxxxxx>

Could you take some time and figure out which structs should actually
be packed and which should not?  For example, in net_pkt_rcv the
pointers are not aligned so it will cause a slow down on x86 and crash
on other arches (which we don't care about).

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux