> -----Original Message----- > From: Dan Carpenter [mailto:dan.carpenter@xxxxxxxxxx] > Sent: Friday, June 19, 2015 8:55 AM > To: Kershner, David A > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; Jes.Sorensen@xxxxxxxxxx; *S-Par- > Maintainer; driverdev-devel@xxxxxxxxxxxxxxxxxxxxxx; Romer, Benjamin M > Subject: Re: [PATCH v2 2/3] staging: unisys: convert pack pragma to > __packed > > On Fri, Jun 12, 2015 at 04:46:07PM -0400, David Kershner wrote: > > It was noticed that iochannel.h was still using pragmas to > > pack the datastructures, should be using __packed instead. > > > > Signed-off-by: David Kershner <david.kershner@xxxxxxxxxx> > > Could you take some time and figure out which structs should actually > be packed and which should not? For example, in net_pkt_rcv the > pointers are not aligned so it will cause a slow down on x86 and crash > on other arches (which we don't care about). > > regards, > dan carpenter Dan, Thanks for the find. Unfortunately, all the structs defined in iochannel.h need to be packed since they are shared across different OS and code instances. I'll look into changing the s-Par firmware and will update the iochannels structure as well. Your reference to x86, does that include x86_64? Thanks, David _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
