On Sat, Jun 13, 2015 at 02:16:18PM +0530, Sudip Mukherjee wrote: > > can you please have a look (when you are free) at it to see if anything > else needs to be done. Remove any unused macros. Cleanup indenting in the .h file. drivers/staging/sm7xxfb/sm7xxfb.c:821 smtcfb_pci_probe() warn: 'smtc_regbaseaddress' can't be NULL. move the BIG_ENDIAN ifdefs to the .h file. I don't understand why only big endian systems get a fb_read/write? Cleanup casts in fb_read/write. cleanup comments. make sure they are up to date and make sense. cleanup function declarations. Make the style consistent. run checkpatch.pl --strict Remind me we need the #ifndef MODULE? regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
