On Mon, 2015-06-15 at 10:47 +0530, Sudip Mukherjee wrote: > On Sat, Jun 13, 2015 at 09:57:05AM -0700, Joe Perches wrote: > > It's unfortunate there are so many #ifdef __BIG_ENDIAN uses. > instead of #ifdef __BIG_ENDIAN can i then use a bool flag to check by if-else? I think that'd be worse. Moving the #ifdef into the .h may be better, but <shrug>, whatever works well enough. Another thing may be to move the vgamode array declaration in fb7xx.h to the .c file and make it const and remove the #define numvgamodes and just use ARRAY_SIZE directly in the one place it's used. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
