On Mon, Mar 16, 2015 at 04:33:02PM +0100, Greg KH wrote: > On Sat, Mar 07, 2015 at 10:56:52AM +0530, Sudip Mukherjee wrote: > > these variables were assigned some values but they were never being > > reused again. > > But some of them should have been checked, right? Or, if no one cares, > fix up the function to not return anything, like for all of the > read_register() calls. > > Please do that instead. but the return value of ft1000_read_register() is being used in some places like card_send_command() or in ft1000_ioctl(). we can use the return value (if error) in the poll() or ioctl() instead of returning -1 or -ENOTTY. but in the other places, its - no one cares. regards sudip > > thanks, > > greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
