Re: [PATCH 2/2] staging: ft1000: remove code indention

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 16, 2015 at 04:33:34PM +0100, Greg Kroah-Hartman wrote:
> On Sat, Mar 07, 2015 at 10:56:53AM +0530, Sudip Mukherjee wrote:
> > modified the code to keep the logic same but removed some indention.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
> > ---
> > 
> > this patch will generate checkpatch warning about line more than 80char,
> > and too many use of tab. but unless the total function is rewrtten it will
> > be difficult to fix that.
> > 
> >  drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 44 +++++++++++-------------
> >  1 file changed, 21 insertions(+), 23 deletions(-)
> 
> I don't see how this looks any better, do you?
well, better in the sense very little indention was fixed and code
which was repeating in if-else if - else was placed in a loop, but a
small if-else was still there for the different delay between retries.
I will see if i can make it more better.

regards
sudip
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux