Re: [PATCH 1/2] staging: ft1000: remove unused variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Mar 07, 2015 at 10:56:52AM +0530, Sudip Mukherjee wrote:
> these variables were assigned some values but they were never being
> reused again.

But some of them should have been checked, right?  Or, if no one cares,
fix up the function to not return anything, like for all of the
read_register() calls.

Please do that instead.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux