On Sat, Mar 14, 2015 at 02:30:51PM -0700, Ragavendra Nagraj wrote:
> This patch fixes the no spaces and indent warnings identified by the checkpath.pl
> script for the entire ddk750_chip.c file by using appropriate tab spaces
> and indents accordingly.
>
> Signed-off-by: Ragavendra Nagraj <ragavendra.bn@xxxxxxxxx>
> ---
> drivers/staging/sm750fb/ddk750_chip.c | 454 ++++++++++++++++-----------------
> 1 file changed, 227 insertions(+), 227 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index b71169e..715baae 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -20,22 +20,22 @@ logical_chip_type_t getChipType()
> physicalID = devId750;//either 0x718 or 0x750
> physicalRev = revId750;
>
> - if (physicalID == 0x718)
> - {
> - chip = SM718;
> - }
> - else if (physicalID == 0x750)
> - {
> - chip = SM750;
> + if (physicalID == 0x718)
> + {
> + chip = SM718;
> + }
here the code was:
if (physicalID == 0x718)
{
chip = SM718;
}
the problem was that space was used for indention.
but your patch will make it to:
if (physicalID == 0x718)
{
chip = SM718;
}
you have used tabs, that is correct but you have introduced a new style
problem now.
and please do mark the version in the patch subject, else it is
becoming confusing about which is the latest one.
regards
sudip
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
