On Sun, Mar 15, 2015 at 01:24:24AM -0700, Ragavendra wrote:
> ohh ok, is that the only fix that needs to be added. I don't mind fixing
> that and sending if required.
>
> Anyway that brace needs to be on the same line as per the coding standards
> otherwise we get "ERROR: that open brace { should be on the previous line"
> in checkpath and I planned to fix this eventually. So do you want me to do
> this instead of the first one. Please advice.
the code was:
if (physicalID == 0x718)
{
chip = SM718;
}
so after your patch it should not be:
if (physicalID == 0x718)
{
^^^^^^^^
chip = SM718;
}
i have marked where the problem is. you are giving an extra tab before
the opening brace and introducing new style warnings there.
it should be :
if (physicalID == 0x718)
{
chip = SM718;
}
regards
sudip
>
> --
> Thanks & regards,
> Ragavendra BN
>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
