On Mon, Feb 09, 2015 at 07:47:48PM +0800, Matt Tyler wrote: > On Sun, Feb 08, 2015 at 09:44:43PM +0800, Greg KH wrote: > > On Sun, Feb 08, 2015 at 09:26:15PM +0800, Matthew Tyler wrote: > > > Sparse is currently throwing warnings as insert_proc and remove_proc > > > are not defined. > > > > > > The patch adds definitions for these files in a suitable header file. > > > > > > These only seem to be exported by one location - libcfs/module.c > > > > > > Can we remove the export and import from the header? > > > > Why not just move the functions to that one .c file that uses it, and > > make them static? That would be easier and would get rid of a horrid > > global symbol name. > > > > thanks, > > > > greg k-h > > It looks like it is primarily for separation of concerns; those two > functions register a table full of proc handlers which are defined > in their current parent file. > > We could merge the two files and remove the global symbol name? > > Or is better to maintain the separation of functionality, and create > an extra header? Merge it, especially given how far apart in the tree the two files are, they don't have any obvious linkage like putting it in one file will show. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
