On Sun, Feb 08, 2015 at 09:26:15PM +0800, Matthew Tyler wrote: > Sparse is currently throwing warnings as insert_proc and remove_proc > are not defined. > > The patch adds definitions for these files in a suitable header file. > > These only seem to be exported by one location - libcfs/module.c > > Can we remove the export and import from the header? Why not just move the functions to that one .c file that uses it, and make them static? That would be easier and would get rid of a horrid global symbol name. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
