Sparse is currently throwing warnings as insert_proc and remove_proc are not defined. The patch adds definitions for these files in a suitable header file. These only seem to be exported by one location - libcfs/module.c Can we remove the export and import from the header? Signed-off-by: Matthew Tyler <matt.tyler@xxxxxxxxxxxx> --- .../lustre/lustre/libcfs/linux/linux-proc.c | 2 ++ .../lustre/lustre/libcfs/linux/linux-proc.h | 41 ++++++++++++++++++++++ 2 files changed, 43 insertions(+) create mode 100644 drivers/staging/lustre/lustre/libcfs/linux/linux-proc.h diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c b/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c index c539e37..a5ffdad 100644 --- a/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c +++ b/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c @@ -59,6 +59,8 @@ #include <linux/proc_fs.h> #include <linux/sysctl.h> +#include "linux-proc.h" + # define DEBUG_SUBSYSTEM S_LNET #include "../../../include/linux/libcfs/libcfs.h" diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.h b/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.h new file mode 100644 index 0000000..c78a4da --- /dev/null +++ b/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.h @@ -0,0 +1,41 @@ +/* + * GPL HEADER START + * + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 only, + * as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * General Public License version 2 for more details (a copy is included + * in the LICENSE file that accompanied this code). + * + * You should have received a copy of the GNU General Public License + * version 2 along with this program; If not, see + * http://www.sun.com/software/products/lustre/docs/GPLv2.pdf + * + * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, + * CA 95054 USA or visit www.sun.com if you need additional information or + * have any questions. + * + * GPL HEADER END + */ +/* + * Copyright (c) 2009, 2010, Oracle and/or its affiliates. All rights reserved. + * Use is subject to license terms. + */ +/* + * This file is part of Lustre, http://www.lustre.org/ + * Lustre is a trademark of Sun Microsystems, Inc. + */ + +#ifndef __LIBCFS_LINUX_PROC_H__ +#define __LIBCFS_LINUX_PROC_H__ + +int insert_proc(void); +void remove_proc(void); + +#endif -- 2.2.2 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
