On Thu, 2015-01-22 at 11:19 +0800, Greg KH wrote: > On Wed, Jan 21, 2015 at 06:53:31PM +0300, Dan Carpenter wrote: > > Generally "delete code" patches are easy to review. But sometimes you > > have to change formatting and remove variables and curly braces. > > > > $ grep LOG drivers/staging/unisys/ -R | wc -l > > 415 > > > > There isn't a firm rule on way a patch is just too big and annoying to > > review. Probably break it up into: > > > > [patch 1/x] delete LOGINF() > > [patch 2/x] delete LOGERR() > > ... > > Yes, this would be best. > > Always remember, what would you like to have to review if you were the > receiver of patches? > > thanks, > > greg k-h Thank you both for the feedback. :) I'll do one patch per macro. -- Ben _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
