On Fri, 2015-01-09 at 17:40 -0800, Greg KH wrote: > On Fri, Dec 05, 2014 at 05:09:30PM -0500, Benjamin Romer wrote: > > Get rid of LOGWRN() and all related macros, and call pr_warn() directly instead. > > Side note, are you setting pr_fmt() properly so that everything is > "unified" with these messages? No driver subsystem should ever use a > pr_* call unless it is at startup / shutdown where there is no hardware > involved. I think that's not the case here so use the correct dev_* > versions instead. > > thanks, > > greg k-h Greg, You're absolutely right that almost all of the messages being output in our code aren't useful from a user's perspective, so what I'd like to do is to just remove all of the logging macros in one set of patches, and then re-introduce a small number of properly-coded error messages in appropriate spots in a later set of patches. Would that be okay? If so, is it alright to take out one set of macros per patch, or is that too much at once? Thanks! -- Ben _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
