Re: [PATCH 55/69] staging: unisys: get rid of LOGWRN() macro and uisklog.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Generally "delete code" patches are easy to review.  But sometimes you
have to change formatting and remove variables and curly braces.

$ grep LOG drivers/staging/unisys/ -R | wc -l
415

There isn't a firm rule on way a patch is just too big and annoying to
review.  Probably break it up into:

[patch 1/x] delete LOGINF()
[patch 2/x] delete LOGERR()
...

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux