Generally "delete code" patches are easy to review. But sometimes you have to change formatting and remove variables and curly braces. $ grep LOG drivers/staging/unisys/ -R | wc -l 415 There isn't a firm rule on way a patch is just too big and annoying to review. Probably break it up into: [patch 1/x] delete LOGINF() [patch 2/x] delete LOGERR() ... regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel