Re: [PATCH] staging:gs_fpgaboot: Remove KERN_INFO in pr_info()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



That should clean up. Thank you.

Reviewed-by: Insop Song <insop.song@xxxxxxxxxxxxx>

ISS

On Fri, Oct 03, 2014 at 10:37:46AM -0700, Joe Perches wrote:
> On Fri, 2014-10-03 at 10:18 -0700, Joe Perches wrote:
> > On Sat, 2014-10-04 at 01:59 +0900, Masanari Iida wrote:
> > > This patch remove unnecessary KERN_INFO in pr_info()
> > []
> > > diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
> > []
> > > @@ -58,7 +58,7 @@ static void datadump(char *msg, void *m, int n)
> > >  
> > >  	for (i = 0; i < n; i++) {
> > >  		if ((i&0xf) == 0)
> > > -			pr_info(KERN_INFO "\n  0x%4x: ", i);
> > > +			pr_info("\n  0x%4x: ", i);
> > >  
> > >  		pr_info("%02X ", c[i]);
> > >  	}
> > 
> > OK, but this block should use print_hex_dump instead.
> 
> Maybe:
> ---
>  drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 25 ++-----------------------
>  1 file changed, 2 insertions(+), 23 deletions(-)
> 
> diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
> index 6aa9d7c..9764a9a 100644
> --- a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
> +++ b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
> @@ -46,27 +46,6 @@ static char	*file = "xlinx_fpga_firmware.bit";
>  module_param(file, charp, S_IRUGO);
>  MODULE_PARM_DESC(file, "Xilinx FPGA firmware file.");
>  
> -#ifdef DEBUG_FPGA
> -static void datadump(char *msg, void *m, int n)
> -{
> -	int i;
> -	unsigned char *c;
> -
> -	pr_info("=== %s ===\n", msg);
> -
> -	c = m;
> -
> -	for (i = 0; i < n; i++) {
> -		if ((i&0xf) == 0)
> -			pr_info(KERN_INFO "\n  0x%4x: ", i);
> -
> -		pr_info("%02X ", c[i]);
> -	}
> -
> -	pr_info("\n");
> -}
> -#endif /* DEBUG_FPGA */
> -
>  static void read_bitstream(char *bitdata, char *buf, int *offset, int rdsize)
>  {
>  	memcpy(buf, bitdata + *offset, rdsize);
> @@ -220,9 +199,9 @@ static int gs_download_image(struct fpgaimage *fimage, enum wbus bus_bytes)
>  	size = fimage->lendata;
>  
>  #ifdef DEBUG_FPGA
> -	datadump("bitfile sample", bitdata, 0x100);
> +	print_hex_dump_bytes("bitfile sample: ", DUMP_PREFIX_OFFSET,
> +			     bitdata, 0x100);
>  #endif /* DEBUG_FPGA */
> -
>  	if (!xl_supported_prog_bus_width(bus_bytes)) {
>  		pr_err("unsupported program bus width %d\n",
>  				bus_bytes);
> 
> 
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux