On Sat, 2014-10-04 at 01:59 +0900, Masanari Iida wrote:
> This patch remove unnecessary KERN_INFO in pr_info()
[]
> diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
[]
> @@ -58,7 +58,7 @@ static void datadump(char *msg, void *m, int n)
>
> for (i = 0; i < n; i++) {
> if ((i&0xf) == 0)
> - pr_info(KERN_INFO "\n 0x%4x: ", i);
> + pr_info("\n 0x%4x: ", i);
>
> pr_info("%02X ", c[i]);
> }
OK, but this block should use print_hex_dump instead.
static void datadump(char *msg, void *m, int n)
{
print_hex_dump(KERN_INFO, msg, DUMP_PREFIX_OFFSET, 16, 1,
m, n, false);
}
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
