On Wed, 2014-07-02 at 14:54 -0700, Andrew Morton wrote:
> On Wed, 2 Jul 2014 16:20:24 +0300 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
[]
> > + pr_err("Test '%s' failed: flags = %u\n", name, flags);
> > +
> > + print_hex_dump(KERN_WARNING, "Input: ", DUMP_PREFIX_NONE, 16, 1,
> > + in, p, true);
> > + print_hex_dump(KERN_WARNING, "Expected: ", DUMP_PREFIX_NONE, 16, 1,
> > + out_test, q_test, true);
> > + print_hex_dump(KERN_WARNING, "Got: ", DUMP_PREFIX_NONE, 16, 1,
> > + out_real, q_real, true);
>
> Seems strange to mix KERN_ERR and KERN_WARNING. The code's always been
> that way, but maybe it can be improved.
Will fix this.
--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
Intel Finland Oy
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
