On Wed, 2 Jul 2014 16:20:24 +0300 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> This patch prepares test suite for a following update. It introduces
> test_string_check_buf() helper which checks the result and dumps an error.
>
> ...
>
> --- a/lib/test-string_helpers.c
> +++ b/lib/test-string_helpers.c
> @@ -10,6 +10,26 @@
> #include <linux/string.h>
> #include <linux/string_helpers.h>
>
> +static __init bool test_string_check_buf(const char *name, unsigned int flags,
> + char *in, size_t p,
> + char *out_real, size_t q_real,
> + char *out_test, size_t q_test)
> +{
> + if (q_real == q_test && !memcmp(out_test, out_real, q_test))
> + return true;
> +
> + pr_err("Test '%s' failed: flags = %u\n", name, flags);
> +
> + print_hex_dump(KERN_WARNING, "Input: ", DUMP_PREFIX_NONE, 16, 1,
> + in, p, true);
> + print_hex_dump(KERN_WARNING, "Expected: ", DUMP_PREFIX_NONE, 16, 1,
> + out_test, q_test, true);
> + print_hex_dump(KERN_WARNING, "Got: ", DUMP_PREFIX_NONE, 16, 1,
> + out_real, q_real, true);
Seems strange to mix KERN_ERR and KERN_WARNING. The code's always been
that way, but maybe it can be improved.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
