Re: [PATCH v2 0/3] staging: comedi: addi_apci_1564: miscellaneous fixes and cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2014-07-03 03:15, Chase Southwood wrote:
This patchset moves a misplaced include to the proper file, swaps out an overly
aggressive placement of apci1564_reset(), and cleans up apci1564_interrupt().

Chase Southwood (3):
   staging: comedi: addi_apci_1564: move addi_watchdog.h include to
     addi_apci_1564.c
   staging: comedi: addi_apci_1564: fix use of apci1564_reset() to
     disable DI interrupts
   staging: comedi: addi_apci_1564: clean up apci1564_interrupt()

  .../comedi/drivers/addi-data/hwdrv_apci1564.c      |   2 -
  drivers/staging/comedi/drivers/addi_apci_1564.c    | 139 +++++----------------
  2 files changed, 32 insertions(+), 109 deletions(-)


Looks good! You didn't list the v2 changes though. Maybe you could summarize them here?

Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx.>

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux