On Mon, Jun 23, 2014 at 2:33 PM, Kristina Martšenko <kristina.martsenko@xxxxxxxxx> wrote: > > Here is an example of another driver being moved out: > http://www.spinics.net/lists/linux-usb/msg100924.html > Thanks Kristina. checkpatch reports 1 errors and 17 warnings on the current driver. I guess I need to first submit patches to staging-next to address these issues, and then submit another patch to move it out of staging, right? The last reported error does seem like a false positive to me. Thanks, Ben ### WARNING: please write a paragraph that describes the config symbol fully #100: FILE: drivers/net/wimax/gdm72xx/Kconfig:5: +menuconfig WIMAX_GDM72XX WARNING: please write a paragraph that describes the config symbol fully #108: FILE: drivers/net/wimax/gdm72xx/Kconfig:13: +config WIMAX_GDM72XX_QOS WARNING: please write a paragraph that describes the config symbol fully #112: FILE: drivers/net/wimax/gdm72xx/Kconfig:17: +config WIMAX_GDM72XX_K_MODE WARNING: please write a paragraph that describes the config symbol fully #123: FILE: drivers/net/wimax/gdm72xx/Kconfig:28: +config WIMAX_GDM72XX_USB CHECK: spinlock_t definition without comment #200: FILE: drivers/net/wimax/gdm72xx/gdm_qos.c:33: + spinlock_t lock; CHECK: spinlock_t definition without comment #682: FILE: drivers/net/wimax/gdm72xx/gdm_qos.h:67: + spinlock_t qos_lock; WARNING: networking block comments don't use an empty /* line, use /* Comment... #1140: FILE: drivers/net/wimax/gdm72xx/gdm_sdio.c:443: +/* + * Handle the HCI, WIMAX_SDU_TX_FLOW. WARNING: networking block comments don't use an empty /* line, use /* Comment... #1163: FILE: drivers/net/wimax/gdm72xx/gdm_sdio.c:466: + /* + * If free buffer for sdu tx doesn't exist, then tx queue WARNING: Missing a blank line after declarations #1438: FILE: drivers/net/wimax/gdm72xx/gdm_sdio.h:27: + int len; + void (*callback)(void *cb_data); CHECK: spinlock_t definition without comment #1448: FILE: drivers/net/wimax/gdm72xx/gdm_sdio.h:37: + spinlock_t lock; WARNING: Missing a blank line after declarations #1456: FILE: drivers/net/wimax/gdm72xx/gdm_sdio.h:45: + struct rx_cxt *rx_cxt; + void (*callback)(void *cb_data, void *data, int len); CHECK: spinlock_t definition without comment #1464: FILE: drivers/net/wimax/gdm72xx/gdm_sdio.h:53: + spinlock_t lock; WARNING: networking block comments don't use an empty /* line, use /* Comment... #1822: FILE: drivers/net/wimax/gdm72xx/gdm_usb.c:342: + /* + * In some cases, USB Module of WiMax is blocked when data size is WARNING: networking block comments don't use an empty /* line, use /* Comment... #1923: FILE: drivers/net/wimax/gdm72xx/gdm_usb.c:443: + /* + * If free buffer for sdu tx doesn't CHECK: Blank lines aren't necessary after an open brace '{' #2115: FILE: drivers/net/wimax/gdm72xx/gdm_usb.c:635: + (idProduct & B_DOWNLOAD) == 0) { + CHECK: Blank lines aren't necessary after an open brace '{' #2193: FILE: drivers/net/wimax/gdm72xx/gdm_usb.c:713: + while (!k_mode_stop) { + CHECK: Blank lines aren't necessary after an open brace '{' #2196: FILE: drivers/net/wimax/gdm72xx/gdm_usb.c:716: + while (!list_empty(&k_list)) { + WARNING: Missing a blank line after declarations #2317: FILE: drivers/net/wimax/gdm72xx/gdm_usb.h:33: + u8 *buf; + void (*callback)(void *cb_data); CHECK: spinlock_t definition without comment #2328: FILE: drivers/net/wimax/gdm72xx/gdm_usb.h:44: + spinlock_t lock; WARNING: Missing a blank line after declarations #2336: FILE: drivers/net/wimax/gdm72xx/gdm_usb.h:52: + u8 *buf; + void (*callback)(void *cb_data, void *data, int len); CHECK: spinlock_t definition without comment #2343: FILE: drivers/net/wimax/gdm72xx/gdm_usb.h:59: + spinlock_t lock; CHECK: spinlock_t definition without comment #2422: FILE: drivers/net/wimax/gdm72xx/gdm_wimax.c:54: + spinlock_t evt_lock; WARNING: unchecked sscanf return value #2662: FILE: drivers/net/wimax/gdm72xx/gdm_wimax.c:294: + sscanf(e->dev->name, "wm%d", &idx); WARNING: networking block comments start with * on subsequent lines #2952: FILE: drivers/net/wimax/gdm72xx/gdm_wimax.c:584: + /*NOTE: gdm_update_fsm should be called + before gdm_wimax_ioctl_set_data is called*/ WARNING: networking block comments put the trailing */ on a separate line #2952: FILE: drivers/net/wimax/gdm72xx/gdm_wimax.c:584: + before gdm_wimax_ioctl_set_data is called*/ WARNING: Missing a blank line after declarations #3375: FILE: drivers/net/wimax/gdm72xx/gdm_wimax.h:39: + struct net_device *netdev; + int (*send_func)(void *priv_dev, void *data, int len, WARNING: networking block comments don't use an empty /* line, use /* Comment... #3518: FILE: drivers/net/wimax/gdm72xx/hci.h:116: +/* + * TLV ERROR: Macros with complex values should be enclosed in parenthesis #4429: FILE: drivers/net/wimax/gdm72xx/usb_ids.h:34: +#define USB_DEVICE_BOOTLOADER(vid, pid) \ + {USB_DEVICE((vid), ((pid)&BL_PID_MASK)|B_DOWNLOAD)}, \ + {USB_DEVICE((vid), ((pid)&BL_PID_MASK)|B_DOWNLOAD|B_DIFF_DL_DRV)} _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
