Re: [PATCH 72/74] staging: rtl8723au: rtw_mlme_ext.c: Fixup some more unreadable formatting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes:
> On Wed, May 21, 2014 at 09:38:36AM +0200, Jes.Sorensen@xxxxxxxxxx wrote:
>> @@ -6243,7 +6241,7 @@ int setkey_hdl23a(struct rtw_adapter *padapter, const u8 *pbuf)
>>  		pmlmeinfo->key_index = pparm->keyid;
>>  
>>  	/* write cam */
>> -	ctrl = BIT(15) | ((pparm->algorithm) << 2) | pparm->keyid;
>> +	ctrl = BIT(15) | (pparm->algorithm) << 2 | pparm->keyid;
>                          ^^^^^^^^^^^^^^^^^^^^^^^
> Heh.  It doesn't matter either way, but if I had to choose I would
> probably have kept the outer parens.  :P
>
> Anyway, I'm done reviewing this patch set.  Looks good.

I suspect that was my intention and I picked the wrong right side
bracket by mistake :( There is some crazy obsession with excessive
paranthesis abuse in that driver :(

Cheers,
Jes
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux