On Wed, May 21, 2014 at 09:38:36AM +0200, Jes.Sorensen@xxxxxxxxxx wrote: > @@ -6243,7 +6241,7 @@ int setkey_hdl23a(struct rtw_adapter *padapter, const u8 *pbuf) > pmlmeinfo->key_index = pparm->keyid; > > /* write cam */ > - ctrl = BIT(15) | ((pparm->algorithm) << 2) | pparm->keyid; > + ctrl = BIT(15) | (pparm->algorithm) << 2 | pparm->keyid; ^^^^^^^^^^^^^^^^^^^^^^^ Heh. It doesn't matter either way, but if I had to choose I would probably have kept the outer parens. :P Anyway, I'm done reviewing this patch set. Looks good. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel