Re: r8192e_pci driver broken 3.14+

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 21, 2014 at 10:39:43PM -0400, Sean MacLennan wrote:
> On Sat, 19 Apr 2014 16:57:45 -0400
> Sean MacLennan <seanm@xxxxxxxx> wrote:
> 
> > A sparse error fixup removed a htons() which is required for the
> > driver to function. This patch puts the htons() back and fixes the
> > sparse warning correctly by changing the left side cast.
> > 
> > Signed-off-by: Sean MacLennan <seanm@xxxxxxxx>
> > ---
> > diff --git a/drivers/staging/rtl8192e/rtllib_tx.c
> > b/drivers/staging/rtl8192e/rtllib_tx.c index 11d0a9d..b7dd153 100644
> > --- a/drivers/staging/rtl8192e/rtllib_tx.c
> > +++ b/drivers/staging/rtl8192e/rtllib_tx.c
> > @@ -171,7 +171,7 @@ inline int rtllib_put_snap(u8 *data, u16 h_proto)
> >  	snap->oui[1] = oui[1];
> >  	snap->oui[2] = oui[2];
> >  
> > -	*(u16 *)(data + SNAP_SIZE) = h_proto;
> > +	*(__be16 *)(data + SNAP_SIZE) = htons(h_proto);
> >  
> >  	return SNAP_SIZE + sizeof(u16);
> >  }
> 
> Any status on this patch?

Ah, as the subject didn't look like a patch to apply, it got dropped
from my patch queue.  Care to resend it with a descriptive subject that
matches things that we are expecting?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux