Re: [staging:staging-next 133/193] drivers/staging/rtl8723au/core/rtw_mlme_ext.c:1236 OnAssocReq23a() error: we previously assumed 'p' could be null (see line 1234)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> staging-next
> head:   dff222670ebebf1a7f147a23ccb5fc0312f2ae7e
> commit: da290c54610f49ef475f7f88668259216b08fc36 [133/193] staging:
> rtl8723au: OnAssocReq23a(): Clean up and use more ieee80211.h
>
> New smatch warnings:
> drivers/staging/rtl8723au/core/rtw_mlme_ext.c:1236 OnAssocReq23a()
> error: we previously assumed 'p' could be null (see line 1234)

OUF! Nice catch!

> Old smatch warnings:
> drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4362
> collect_bss_info23a() error: __builtin_memcpy() 'bssid->IEs' too small
> (768 vs u32max)
> drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4860 process_80211d()
> error: testing array offset 'i' after use.

We already have a check in palce here - do I need to make the
if (length > MAX_IE_SZ) check for length < 0 to make this warning go
away?

Thanks,
Jes
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux