On 2014-04-16 22:19, H Hartley Sweeten wrote:
Step 5 of the (*do_cmdtest) validates that the cmd->chanlist is compatible with the hardware. As pointed out by Ian Abbott, some of the step 5 operations are buggy because they access the cmd->chanlist[] without checking the cmd->chanlist_len. This series factors out step 5 from (*do_cmdtest) functions and cleans up the code. H Hartley Sweeten (15): staging: comedi: adl_pci9111: factor out chanlist checking from (*do_cmdtest) staging: comedi: amplc_pci224: factor out chanlist checking from (*do_cmdtest) staging: comedi: amplc_pci230: factor out chanlist checking from (*do_cmdtest) staging: comedi: cb_pcidas: factor out chanlist checking from (*do_cmdtest) staging: comedi: cb_pcidas64: factor out chanlist checking from (*do_cmdtest) staging: comedi: das16: factor out chanlist checking from (*do_cmdtest) staging: comedi: das16m1: factor out chanlist checking from (*do_cmdtest) staging: comedi: das1800: factor out chanlist checking from (*do_cmdtest) staging: comedi: das800: factor out chanlist checking from (*do_cmdtest) staging: comedi: dmm32at: factor out chanlist checking from (*do_cmdtest) staging: comedi: gsc_hpdi: factor out chanlist checking from (*do_cmdtest) staging: comedi: ni_at_a2150: factor out chanlist checking from (*do_cmdtest) staging: comedi: ni_mio_common: factor out chanlist checking from (*do_cmdtest) staging: comedi: me4000: tidy up the chanlist checking staging: comedi: ni_labpc: tidy up the chanlist checking drivers/staging/comedi/drivers/adl_pci9111.c | 68 +++--- drivers/staging/comedi/drivers/amplc_pci224.c | 76 +++--- drivers/staging/comedi/drivers/amplc_pci230.c | 313 +++++++++++-------------- drivers/staging/comedi/drivers/cb_pcidas.c | 80 ++++--- drivers/staging/comedi/drivers/cb_pcidas64.c | 110 +++++---- drivers/staging/comedi/drivers/das16.c | 51 ++-- drivers/staging/comedi/drivers/das16m1.c | 49 ++-- drivers/staging/comedi/drivers/das1800.c | 37 +-- drivers/staging/comedi/drivers/das800.c | 52 ++-- drivers/staging/comedi/drivers/dmm32at.c | 51 ++-- drivers/staging/comedi/drivers/gsc_hpdi.c | 34 ++- drivers/staging/comedi/drivers/me4000.c | 75 ++---- drivers/staging/comedi/drivers/ni_at_a2150.c | 74 +++--- drivers/staging/comedi/drivers/ni_labpc.c | 84 +++---- drivers/staging/comedi/drivers/ni_mio_common.c | 31 ++- 15 files changed, 625 insertions(+), 560 deletions(-)
All looks fine to me! Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx> -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
