On Thu, Apr 17, 2014 at 11:50:13AM +0200, Jes Sorensen wrote: > > Old smatch warnings: > > drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4362 > > collect_bss_info23a() error: __builtin_memcpy() 'bssid->IEs' too small > > (768 vs u32max) > > drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4860 process_80211d() > > error: testing array offset 'i' after use. > > We already have a check in palce here - do I need to make the > if (length > MAX_IE_SZ) check for length < 0 to make this warning go > away? Oh. Wait. I responded to the wrong thing. Yeah. You could check for negatives or make length unsigned or you could check skb->len to make sure it wasn't too short. Any of those would work. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
