2014-03-18 9:37 GMT+09:00 Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>: > On Tue, Mar 18, 2014 at 09:26:07AM +0900, DaeSeok Youn wrote: >> I think vmalloc/kmalloc in uislib_malloc() can be removed and just use >> vmalloc/kmalloc directly. > > Yes. Actually, just use kmalloc, I don't knwo why vmalloc is being > used, but cc: the driver maintainers just to be sure. It try to allocate 128KiB(131072byte) with vmalloc(). I think if it trying to allocate with kmalloc() it has a possibility to fail because of memory fragmentation even if system has enough memory to use. Just my opinion. If I'm wrong, let me know. > >> (UISMALLOC() macro is also removed.) > > Yes. > >> And uislib_malloc() is renamed to "uislib_trace_buffer_status()" which >> is just tracing buffer status(Malloc_FailuresAlloc, Malloc_BytesInUse >> ...) for info_proc_read_helper(). > > The whole tracing stuff needs to be ripped out, so no problem deleting > it here as well. OK. I will remove that information in info_proc_read_helper(). > >> If this change is accepted, it also need to change uislib_free(). > > Drop it and just use kfree(). OK. replace kfree() with uislib_free(). > > thanks, > > greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
