Re: [PATCH 1/7 RESEND] staging: et131x: reduce split lines in et131x_config_rx_dma_regs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Dec 07, 2013 at 09:19:04AM +0800, ZHAO Gang wrote:
> Signed-off-by: ZHAO Gang <gamerh2o@xxxxxxxxx>
> ---
>  drivers/staging/et131x/et131x.c | 25 +++++++++++--------------
>  1 file changed, 11 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
> index e3a71d3..0372f23 100644
> --- a/drivers/staging/et131x/et131x.c
> +++ b/drivers/staging/et131x/et131x.c
> @@ -1822,6 +1822,8 @@ static void et131x_config_rx_dma_regs(struct et131x_adapter *adapter)
>  		u32 __iomem *base_hi;
>  		u32 __iomem *base_lo;
>  
> +		struct fbr_lookup *fbr = rx_local->fbr[id];
> +

Gar no.  I'm sorry.  Please keep all the declarations in one block...

I was fine with the previous version honestly, sorry to make you redo
these over and over.

Don't put RESEND in the subject unless you are resending them unchanged
because the maintainers ignored them the first time.  Put a v2, or v3
there instead.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux