Re: [PATCH] staging: rtl8192u: fix some type confusion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 06, 2013 at 11:59:26PM -0500, Ilia Mirkin wrote:
> The first 8 bytes of skb->cb are used to store a struct net_device *.
> Adjust the memcpy's src/dst types to reflect that.
> 
> Signed-off-by: Ilia Mirkin <imirkin@xxxxxxxxxxxx>

This isn't right.  The correct fix is just to remove all the casting.

	memcpy(skb->cb, &dev, sizeof(dev));

regards,
dan carpenter


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux