On Fri, Dec 06, 2013 at 09:35:00PM +0800, ZHAO Gang wrote: > Signed-off-by: ZHAO Gang <gamerh2o@xxxxxxxxx> > --- > drivers/staging/et131x/et131x.c | 26 ++++++++++++-------------- > 1 file changed, 12 insertions(+), 14 deletions(-) > > diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c > index e3a71d3..ee231f2 100644 > --- a/drivers/staging/et131x/et131x.c > +++ b/drivers/staging/et131x/et131x.c > @@ -1821,6 +1821,9 @@ static void et131x_config_rx_dma_regs(struct et131x_adapter *adapter) > u32 __iomem *min_des; > u32 __iomem *base_hi; > u32 __iomem *base_lo; > + struct fbr_lookup *fbr; > + > + fbr = rx_local->fbr[id]; There's no reason why these three new lines can't be combined into one, i.e. struct fbr_lookup *fbr = rx_local->fbr[id]; The rest of the patch is good. Mark _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel