Re: [PATCH 01/11] staging: et131x: make some tweaks to reduce split lines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 04, 2013 at 03:24:11PM +0800, ZHAO Gang wrote:
> 1. As TODO list suggested, do this sort of things to reduce split lines:
> 	struct fbr_lookup *fbr;
> 	fbr = rx_local->fbr[id];
> 	Then replace all the instances of "rx_local->fbr[id]" with fbr.
> 
> 2. Some code style change

Please, only do ONE thing per patch, not two things, not three things,
only 1.

You are doing multiple things here, right?  Please don't.

Sorry, I can't take this patch, please fix it up and resend.

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux