[PATCH v2 00/26] cleanup debugging support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Currently the COMEDI_DEBUG option enables the comedi_debug module parameter as
well as a DPRINTK() macro. To actually get debug messages to display the 
kernel
still needs to be built with the -DDEBUG flag.

Cleanup all the custom uses of DEBUG in comedi and use the COMEDI_DEBUG option
to enable the ccflag -DDEBUG in the comedi subsystem.

Remove all uses of the DPRINTK macro and just use dev_dbg() or pr_debug() 
instead.
Remove any debug messages that are just added noise.

Tidy up all the private debugging implementations in the comedi drivers.

v2: Rebase series to Greg's staging-next tree.
    Add Ian Abbott's Reviewed-by for patches 1-25

The first 14 patches of the original 39 patch series have already been applied
to Greg's staging-next tree. This series just includes the unapplied patches.
The last patch in this series is new.

H Hartley Sweeten (26):
  staging: comedi: comedi_fops: remove use of DPRINTK
  staging: comedi: ni_pcidio: remove DEBUG_FLAGS define and code
  staging: comedi: ni_pcidio: remove debug_int()
  staging: comedi: ni_pcidio: remove use of DPRINTK
  staging: comedi: remove DPRINTK macro
  staging: comedi: mite: remove MDPRINTK macro
  staging: comedi: mite: remove DEBUG_MITE code
  staging: comedi: cb_pcidas64: remove DEBUG_PRINT
  staging: comedi: gsc_hpdi: remove DEBUG_PRINT
  staging: comedi: ni_at_a2150: remove A2150_DEBUG
  staging: comedi: cb_pcimdas: remove CBPCIMDAS_DEBUG
  staging: comedi: ni_pcimio: remove PCI_DEBUG
  staging: comedi: pcmmio: remove DAMMIT_ITS_BROKEN debug
  staging: comedi: pcmmio: remove commented out debug code
  staging: comedi: dyna_pci10xx: convert a KERN_DEBUG message to dev_dbg()
  staging: comedi: pcmmio: convert a KERN_DEBUG message to dev_dbg()
  staging: comedi: c6xdigio: remove unnecessary c6xdigio_pwmo_insn_read()
  staging: comedi: dt2814: remove disabled irq probe code
  staging: comedi: pcl818: remove an unnecessary printk(KERN_DEBUG ...
  staging: comedi: dmm32at: remove some unnecessary printk(KERN_DEBUG ...
  staging: comedi: ni_mio_common: remove unused NI_CS5529_DEBUG code
  staging: comedi: ni_mio_common: remove DEBUG_DIO messages
  staging: comedi: ni_mio_common: remove DEBUG_STATUS_B messages
  staging: comedi: ni_mio_common: remove DEBUG_STATUS_A messages
  staging: comedi: ni_mio_common: remove DEBUG_INTERRUPT messages
  staging: comedi: unionxx5: tidy up some dev_{level} messages

 drivers/staging/comedi/comedi_fops.c           | 119 ++++++++++---------
 drivers/staging/comedi/comedidev.h             |   2 -
 drivers/staging/comedi/drivers/c6xdigio.c      |   9 --
 drivers/staging/comedi/drivers/cb_pcidas64.c   | 126 +-------------------
 drivers/staging/comedi/drivers/cb_pcimdas.c    |   3 -
 drivers/staging/comedi/drivers/dmm32at.c       |   6 -
 drivers/staging/comedi/drivers/dt2814.c        |  26 ----
 drivers/staging/comedi/drivers/dyna_pci10xx.c  |   3 +-
 drivers/staging/comedi/drivers/gsc_hpdi.c      |  78 ------------
 drivers/staging/comedi/drivers/mite.c          | 143 ----------------------
 drivers/staging/comedi/drivers/mite.h          |  12 --
 drivers/staging/comedi/drivers/ni_at_a2150.c   |  25 ----
 drivers/staging/comedi/drivers/ni_mio_common.c | 157 +------------------------
 drivers/staging/comedi/drivers/ni_pcidio.c     | 129 +-------------------
 drivers/staging/comedi/drivers/ni_pcimio.c     |   2 -
 drivers/staging/comedi/drivers/pcl818.c        |   2 -
 drivers/staging/comedi/drivers/pcmmio.c        |  35 +-----
 drivers/staging/comedi/drivers/unioxx5.c       |  32 ++---
 18 files changed, 97 insertions(+), 812 deletions(-)

-- 
1.8.4.4

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux