On Thu, Sep 05, 2013 at 05:15:02PM -0300, Fabio Estevam wrote:
> Looks good, just one minor suggestion:
>
> On Thu, Sep 5, 2013 at 3:16 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> > +static void lradc_reg_set(struct mxs_lradc *lradc, u32 val, size_t chan)
> > +{
> > + writel(val, lradc->base + chan + STMP_OFFSET_REG_SET);
> > +}
> > +
> > +static void lradc_reg_clear(struct mxs_lradc *lradc, u32 val, size_t chan)
> > +{
> > + writel(val, lradc->base + chan + STMP_OFFSET_REG_CLR);
> > +}
>
> Maybe 'static inline' ?
GCC will already inline these if it thinks they're appropriate for that
treatment.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
