Dear Fabio Estevam,
> On Thu, Sep 5, 2013 at 3:16 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx>
wrote:
> > I have introduced lradc_reg_set() and lradc_reg_clear(). It simplifies
> > the callers and makes the lines shorter.
>
> Looks good, just one minor suggestion:
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> >
> > diff --git a/drivers/staging/iio/adc/mxs-lradc.c
> > b/drivers/staging/iio/adc/mxs-lradc.c index a08c173..da5d04b 100644
> > --- a/drivers/staging/iio/adc/mxs-lradc.c
> > +++ b/drivers/staging/iio/adc/mxs-lradc.c
> > @@ -228,6 +228,16 @@ struct mxs_lradc {
> >
> > #define LRADC_RESOLUTION 12
> > #define LRADC_SINGLE_SAMPLE_MASK ((1 << LRADC_RESOLUTION)
> > - 1)
> >
> > +static void lradc_reg_set(struct mxs_lradc *lradc, u32 val, size_t chan)
> > +{
> > + writel(val, lradc->base + chan + STMP_OFFSET_REG_SET);
> > +}
> > +
> > +static void lradc_reg_clear(struct mxs_lradc *lradc, u32 val, size_t
> > chan) +{
> > + writel(val, lradc->base + chan + STMP_OFFSET_REG_CLR);
> > +}
>
> Maybe 'static inline' ?
static only, the inline is meaningless, GCC will handle that.
Best regards,
Marek Vasut
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
