> From: Aaro Koskinen [mailto:aaro.koskinen@xxxxxx] > Sent: Friday, August 16, 2013 10:33 AM > > On Fri, Aug 16, 2013 at 06:01:50AM -0700, Greg KH wrote: > > It was just pointed out to me by Sebastian that it looks like both the > > octeon-usb and dwc2 drivers in drivers/staging/ are for the same exact > > hardware core. > > > > Were you two aware of this? > > It was mentioned here: > > http://marc.info/?l=linux-driver-devel&m=137028052222213&w=2 > > At the time, I thought octeon-usb was "more mature": "octeon-hcd was > written because we couldn't figure out how to fix the dwc2 driver so > that it wouldn't crash." > > > As the dwc2 code seems to be the "more mature" codebase, any objection > > to me deleting the octeon-usb driver? > > If it's possible to get it working on Octeon HW, then having a single > driver is of course the best solution. Is dwc2 fully functional (there > is no TODO file)? I'll check if I get it working, otherwise I'll be > disappointed if octeon-usb is deleted and I need to carry an out-of-tree > driver to use my board. :-) > > > Aaro, as there is no MODULE_DEVICE_TABLE() set up for the octeon-usb > > code, and your module_init() function where you grab the hardware is, > > let's just say, "odd"[1], it's really hard to determine what hardware > > platforms this code even runs on. Any hints? > > The driver is only buildable for OCTEON SoC, and the function > cvmx_usb_get_num_ports() knows each SoC version if they have the USB > block or not. I was not aware of it. I wonder why there were no emails to me or to the linux-usb list from people who were having trouble getting the dwc2 driver to work on Octeon? If there were any, I didn't see them. Probably I should have a look at the Octeon driver and see if there are any good ideas that can be borrowed for the dwc2 driver. I'm intrigued by the email saying it generates many fewer interrupts than dwc2 does, I would like to see how they accomplish that. To answer Aaro's questions, I have not seen or heard of any crashes with the dwc2 driver with the latest version. I think the driver is "fully functional" in that it handles all types of USB devices that I have tried with it. There are still some problems with it on the Raspberry Pi platform, but those are being worked on. Aaro, I would ask you the same question. Is the Octeon driver fully functional? Are there any shortcomings with it that you know about? I guess a TODO list for dwc2 would be a good idea, I'll work on that. -- Paul _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
