Hi Dan, Thanks, I am fixing the codes now. I plan to send v2 soon. However, most of them are syntactic and style issues, not logical ones. Probably they are due to the proprietary protocols being used between the device and the host, and I do not have enough information to fix those. I will have the original authors to patch more or at least put some explanations. I will try to list up the issues which still need to be addressed. Hi Greg, My organization is also planning to submit modem manager plugins, and I would have the driver codes available as soon as possible. I assume reviews from networking people will take much more time. I would like to ask you to put the codes on staging tree first when I am done with the fixes Dan commented. Thank you all, Won. On Wed, Jul 24, 2013 at 7:02 AM, Greg KH <greg@xxxxxxxxx> wrote: > On Tue, Jul 23, 2013 at 11:43:52AM +0300, Dan Carpenter wrote: >> On Tue, Jul 23, 2013 at 04:40:29PM +0900, Won Kang wrote: >> > Thank you so much for the review. I will try to fix them soon. >> > Should I continue to send patches until reviewers agrees to accept >> > them? I have no experience with submitting codes, and just not sure >> > how to follow up. it's first time for me to do this kind of job. >> > >> >> Always CC the mailing list in case someone has a similar question >> later. >> >> Yes. That's basically the process. >> >> Greg would probably have taken it as-is, if I hadn't said anything. >> Maybe he still will if you want. But going through staging is not >> mandatory if your driver is ok from the start. I don't think >> staging is going to help you much. I've already commented on most >> of the style issues. You need reviews from networking people. > > Yes, I will take it as-is, unless the authors think they can clean it up > in the next month or so to get it merged properly through the networking > tree. > > Personally, I'd recommend doing the work now, and get it merged through > networking, as you will have to do that work anyway, might as well do it > now. > > Won, let me know what you want to do. > > thanks, > > greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
