On Tue, Jul 23, 2013 at 04:40:29PM +0900, Won Kang wrote: > Thank you so much for the review. I will try to fix them soon. > Should I continue to send patches until reviewers agrees to accept > them? I have no experience with submitting codes, and just not sure > how to follow up. it's first time for me to do this kind of job. > Always CC the mailing list in case someone has a similar question later. Yes. That's basically the process. Greg would probably have taken it as-is, if I hadn't said anything. Maybe he still will if you want. But going through staging is not mandatory if your driver is ok from the start. I don't think staging is going to help you much. I've already commented on most of the style issues. You need reviews from networking people. Otherwise for other maintainers you just fix every complaint or send an email saying why the complaint is wrong. Resend the patch with a [patch 1/2 v2] staging: gdm7240: adding LTE USB driver After the signed off by line put: Signed-off-by: You --- v2: cleanup and minor fixes The same for version 3 and so on. This is a network driver so you really need to CC netdev and linux-wireless. You want to make the linux wireless maintainer, John Linville, happy by Aug 9 so he can merge it in time for v3.12. Aug 9 is not much time, so maybe it's a good idea to sit in staging for one kernel release? regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
