Re: [PATCH 1/2] staging: gdm7240: adding LTE USB driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 23, 2013 at 11:43:52AM +0300, Dan Carpenter wrote:
> On Tue, Jul 23, 2013 at 04:40:29PM +0900, Won Kang wrote:
> > Thank you so much for the review. I will try to fix them soon.
> > Should I continue to send patches until reviewers agrees to accept
> > them? I have no experience with submitting codes, and just not sure
> > how to follow up. it's first time for me to do this kind of job.
> > 
> 
> Always CC the mailing list in case someone has a similar question
> later.
> 
> Yes.  That's basically the process.
> 
> Greg would probably have taken it as-is, if I hadn't said anything.
> Maybe he still will if you want.  But going through staging is not
> mandatory if your driver is ok from the start.  I don't think
> staging is going to help you much.  I've already commented on most
> of the style issues.  You need reviews from networking people.

Yes, I will take it as-is, unless the authors think they can clean it up
in the next month or so to get it merged properly through the networking
tree.

Personally, I'd recommend doing the work now, and get it merged through
networking, as you will have to do that work anyway, might as well do it
now.

Won, let me know what you want to do.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux