On Wed, 2013-06-26 at 06:56 -0700, Joe Perches wrote: > On Wed, 2013-06-26 at 12:53 +0100, Rupesh Gujare wrote: > > Above macros look good, however Greg have objection to define new macros > > & he had suggested to use dev_dbg() & pr_debug(). These macros already use pr_debug and should use dev_dbg and netdev_dbg where appropriate and possible. These uses also don't depend on a single saved global "struct device *". The grouping/verbose flags are just as you use them now, but a lot simpler and allow an easy conversion to a runtime module_param. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel