On Tue, 2013-06-25 at 10:02 -0700, Greg KH wrote: > On Tue, Jun 25, 2013 at 05:30:02PM +0100, Rupesh Gujare wrote: > > convert all debug messages from printk to dev_dbg() & add kernel config to > > enable/disable these messages during compilation. > No, just use the built-in dynamic debug code in the kernel, no need to > provide any new macros or functions or most importantly, no new Kconfig > options. I think the Kconfig option is pretty poor too but a long needed extension to dev_dbg is to enable classes of messages by level or mask. There are many existing macros like #define module_dbg(level, fmt, ...) do { if (level >= some_module_var) debug_something(...); } while (0) and #define module_dbg(mask, fmt, ...) do { if (mask & some_module_var) debug_something(...) } while (0) It'd be nice to consolidate those in dev_dbg I'll get 'round to it one day if Jason doesn't. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel