On Wed, 2013-06-26 at 12:53 +0100, Rupesh Gujare wrote: > On 26/06/13 02:00, Joe Perches wrote: > > Use a normal Makefile. > > Convert oz_trace and oz_trace2 to a more normal oz_dbg. > > Consolidate oztrace and ozconfig files to ozdbg.h > > Update #include files. > > Reflow modified lines, fit to 80 cols, align arguments. > > > > Add a couple more oz_<foo>_dbg macros to show how more > > verbose device specific debugging could be added when a > > struct device * or struct netdevice * is available. > > Isn't this patch doing too many changes in single patch? Can we split > this patch into smaller patch series ? > In addition to above, it also :- > 1. Removes few unwanted logs. > 2. Changes macro definition for oz_remember_urb() & oz_forget_urb() to > static inline function when WANT_URB_PARANOIA is not defined. Yeah, sure, please do. It was intended more to inform than be applied. staging is closed for at least a few weeks. Resubmit something like it in as many pieces as you choose later. > Above macros look good, however Greg have objection to define new macros > & he had suggested to use dev_dbg() & pr_debug(). > I will leave it to him, if he is all right to accept new macros for > debug logs. > > Greg, > Your comments please. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
