Re: [PATCH 1/3] rtl8192e cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 31, 2013 at 09:48:09PM -0400, Sean MacLennan wrote:
> > > +#if 0
> > >  struct phy_ofdm_rx_status_rxsc_sgien_exintfflag {
> > >  	u8			reserved:4;
> > >  	u8			rxsc:2;
> > >  	u8			sgi_en:1;
> > >  	u8			ex_intf_flag:1;
> > >  };
> > > +#endif
> > 
> > Didn't you just want to delete this?  The patch ifdefs out some
> > other code below as well.
> 
> No. I wanted to keep it as documentation just in case. But I wanted to
> be sure nobody was using it. What is normal practice here, delete and
> say you can always look it up in the older code?

Yeah.  Delete and look in git history as needed.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux