Re: [PATCH 1/3] rtl8192e cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I just had a patch go in here yesterday so these don't apply any
more, sorry.

On Thu, May 30, 2013 at 10:14:56PM -0400, Sean MacLennan wrote:
> Cleanup the rt_stats structure. Many of the fields where unused and a
> lot of the fields where set but never referenced.
> 
> Signed-off-by: Sean MacLennan <seanm@xxxxxxxx>
> ---
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h b/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h
> index b7bb71f..3c8e922 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h
> @@ -269,12 +269,14 @@ struct log_int_8190 {
>  	u32	nIMR_RXFOVW;
>  };
>  
> +#if 0
>  struct phy_ofdm_rx_status_rxsc_sgien_exintfflag {
>  	u8			reserved:4;
>  	u8			rxsc:2;
>  	u8			sgi_en:1;
>  	u8			ex_intf_flag:1;
>  };
> +#endif

Didn't you just want to delete this?  The patch ifdefs out some
other code below as well.

> @@ -288,57 +231,11 @@ static	void cmpk_handle_tx_status(struct net_device *dev, u8 *pmsg)
>  {
>  	struct cmpk_tx_status rx_tx_sts;	/* */
>  
> +	// SAM FIXME

Get on the ball, Sam!

>  	memcpy((void *)&rx_tx_sts, (void *)pmsg, sizeof(struct cmpk_tx_status));
>  	cmpk_count_tx_status(dev, &rx_tx_sts);
>  }
> @@ -1598,7 +1593,6 @@ static void rtl8192_query_rxphystatus(
>  			tmp_rxsnr = pofdm_buf->rxsnr_X[i];
>  			rx_snrX = (char)(tmp_rxsnr);
>  			rx_snrX /= 2;
> -			priv->stats.rxSNRdB[i] = (long)rx_snrX;

The rx_snrX variable isn't needed now.

>  
>  			RSSI = rtl819x_query_rxpwrpercentage(rx_pwr[i]);
>  			if (priv->brfpath_rxenable[i])

regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux