On 2013-05-31, at 11:29, "Greg Kroah-Hartman" <gregkh@xxxxxxxxxxxxxxxxxxx<mailto:gregkh@xxxxxxxxxxxxxxxxxxx>> wrote: On Sat, Jun 01, 2013 at 01:22:51AM +0800, Peng Tao wrote: From: Niu Yawei <yawei.niu@xxxxxxxxx<mailto:yawei.niu@xxxxxxxxx>> In some cases such as kernel writeback, we shouldn't ignore the layout, otherwise, it could race with layout change undergoing. Intel-bug-id: LU-3160 What can I do with this number? Already discussed - full URL. Lustre-commit: 3141db609d95d379761e3b54899618b4037d38f6 Or this one? This is the Lustre git commit hash, so we can track the commits which have been merged into the kernel tree. Lustre-change: http://review.whamcloud.com/6154 This one is at least informative, so it can stay, if you really want it there, but the others are not relevant to anyone outside of your internal development environment, so do not belong in a Linux kernel commit message, sorry. Per Documentation/SubmittingPatches: "Some people also put extra tags at the end. They'll just be ignored for now, but you can do this to mark internal company procedures or just point out some special detail about the sign-off." Signed-off-by: Niu Yawei <yawei.niu@xxxxxxxxx<mailto:yawei.niu@xxxxxxxxx>> Signed-off-by: Jinshan Xiong <jinshan.xiong@xxxxxxxxx<mailto:jinshan.xiong@xxxxxxxxx>> Reviewed-by: Andreas Dilger <andreas.dilger@xxxxxxxxx<mailto:andreas.dilger@xxxxxxxxx>> Reviewed-by: Fan Yong <fan.yong@xxxxxxxxx<mailto:fan.yong@xxxxxxxxx>> Reviewed-by: Oleg Drokin <oleg.drokin@xxxxxxxxx<mailto:oleg.drokin@xxxxxxxxx>> [updated for upstream kernel submission] What's with the line break and this [] comment? We don't care about that. Also per SubmittingPatches: "...it is recommended that you add a line between the last Signed-off-by header and yours, indicating the nature of your changes. While there is nothing mandatory about this, it seems like prepending the description with your mail and/or name, all enclosed in square brackets, is noticeable enough to make it obvious that you are responsible for last-minute changes." I guess we can remove the obvious ones (minor or no changes from the original patch), and improve the ones with substantive changes to be more descriptive. Cheers, Andreas Signed-off-by: Peng Tao <tao.peng@xxxxxxx<mailto:tao.peng@xxxxxxx>> Signed-off-by: Andreas Dilger <andreas.dilger@xxxxxxxxx<mailto:andreas.dilger@xxxxxxxxx>> It should be a unbroken series of lines here. Care to fix this all up and resend? greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
