Re: [PATCH 01/23] staging/lustre/clio: don't ignore layout on writeback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jun 01, 2013 at 01:22:51AM +0800, Peng Tao wrote:
> From: Niu Yawei <yawei.niu@xxxxxxxxx>
> 
> In some cases such as kernel writeback, we shouldn't ignore the
> layout, otherwise, it could race with layout change undergoing.
> 
> Intel-bug-id: LU-3160

What can I do with this number?

> Lustre-commit: 3141db609d95d379761e3b54899618b4037d38f6

Or this one?

> Lustre-change: http://review.whamcloud.com/6154

This one is at least informative, so it can stay, if you really want it
there, but the others are not relevant to anyone outside of your
internal development environment, so do not belong in a Linux kernel
commit message, sorry.


> Signed-off-by: Niu Yawei <yawei.niu@xxxxxxxxx>
> Signed-off-by: Jinshan Xiong <jinshan.xiong@xxxxxxxxx>
> Reviewed-by: Andreas Dilger <andreas.dilger@xxxxxxxxx>
> Reviewed-by: Fan Yong <fan.yong@xxxxxxxxx>
> Reviewed-by: Oleg Drokin <oleg.drokin@xxxxxxxxx>
> 
> [updated for upstream kernel submission]

What's with the line break and this [] comment?  We don't care about
that.

> Signed-off-by: Peng Tao <tao.peng@xxxxxxx>
> Signed-off-by: Andreas Dilger <andreas.dilger@xxxxxxxxx>

It should be a unbroken series of lines here.

Care to fix this all up and resend?

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux